Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to check Manifest.toml health? #179

Open
nickrobinson251 opened this issue Sep 13, 2023 · 3 comments
Open

Add function to check Manifest.toml health? #179

nickrobinson251 opened this issue Sep 13, 2023 · 3 comments
Labels
enhancement New feature or request new test

Comments

@nickrobinson251
Copy link

If a repository is an application that commits a Manifest.toml, then there are various things you may want to check, similar to how we can check the Project.toml has compat etc.

Some ideas:

  • No deps are tracking a repo directly (no repo-rev/repo-url)
    • alternatively, no deps are tracking a branch of a repo, but are at least fixed to a particular commit or tag (e.g. repo-rev should match [some regex TBD])
  • No deps are pinned
  • No deps are tracking a path
    • alternatively, only a certain path is allowed (e.g. like packages/Foo not ../../Foo)
  • the julia_version matches the version being used to run the tests
    • alternatively, the julia_version matches up to at least the minor version (e.g. 1.9.3 and 1.9.2 both allowed, but 1.8.5 would fail)
@lgoettgens
Copy link
Collaborator

I honestly do not see any serious use-case to commit a top-level Manifest.toml in the first place.

@nickrobinson251
Copy link
Author

if the repo is for building an application, rather than a package. For example, if you are using something like PackageCompiler.jl to create an "app", i.e. an executable, then you may want to control the exact set of dependencies being compiled into the image.

@lgoettgens
Copy link
Collaborator

Hm, okay, seems reasonable.

@lgoettgens lgoettgens added enhancement New feature or request new test labels Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new test
Projects
None yet
Development

No branches or pull requests

2 participants