Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild TZData before benchmarks #360

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

Wynand
Copy link
Contributor

@Wynand Wynand commented Oct 7, 2021

This recompiles TZData before running benchmarks to ensure benchmarks still run when the serialized TZdata is changed

@Wynand Wynand force-pushed the wy/clean-benchmark branch from c3f7a83 to 6a17d86 Compare October 7, 2021 18:02
@Wynand Wynand mentioned this pull request Oct 7, 2021
@Wynand
Copy link
Contributor Author

Wynand commented Oct 7, 2021

Here's how I tested this:

My script for running the benchmarks was

git clean -dfX && julia --project=@. -e 'using Pkg; Pkg.build("TimeZones")'
git fetch origin +:refs/remotes/origin/HEAD
julia --project=benchmark/ -e 'using Pkg; Pkg.instantiate(); Pkg.develop(PackageSpec(path=pwd()))'
julia --project=benchmark/ -e 'using PkgBenchmark, TimeZones; export_markdown(stdout, judge(TimeZones, "origin/HEAD", verbose=false))'

And then when comparing to changes in #354 I added the same changes and ran:

git clean -dfX && julia --project=@. -e 'using Pkg; Pkg.build("TimeZones")'
git fetch origin +:refs/remotes/origin/HEAD
julia --project=benchmark/ -e 'using Pkg; Pkg.instantiate(); Pkg.develop(PackageSpec(path=pwd()))'
julia --project=benchmark/ -e 'using PkgBenchmark, TimeZones; export_markdown(stdout, judge(TimeZones, "wy/clean-benchmark", verbose=false))'

@Wynand Wynand marked this pull request as ready for review October 7, 2021 18:20
@Wynand Wynand force-pushed the wy/clean-benchmark branch from 6a17d86 to 9aa7241 Compare October 7, 2021 18:21
@iamed2 iamed2 merged commit 0e67ab1 into JuliaTime:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants