-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise the min julia version to 1.3 #361
Conversation
1.3 tests are failing as in julia 1.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be okay with setting the minimum to 1.3.2 to clear out this:
Lines 13 to 44 in 0e67ab1
if v"1.3.1-pre.18" <= VERSION < v"1.3.2" | |
using Pkg.Artifacts: do_artifact_str, find_artifacts_toml, load_artifacts_toml | |
# A copy of `Pkg.Artifacts.@artifact_str` where `name` is properly escaped on | |
# Julia 1.3.1 | |
# https://github.com/JuliaLang/Pkg.jl/issues/1912 | |
# https://github.com/JuliaLang/Pkg.jl/pull/1580 | |
macro artifact_str(name) | |
# Load Artifacts.toml at compile time, so that we don't have to use `__source__.file` | |
# at runtime, which gets stale if the `.ji` file is relocated. | |
local artifacts_toml = find_artifacts_toml(string(__source__.file)) | |
if artifacts_toml === nothing | |
error(string( | |
"Cannot locate '(Julia)Artifacts.toml' file when attempting to use artifact '", | |
name, | |
"' in '", | |
__module__, | |
"'", | |
)) | |
end | |
local artifact_dict = load_artifacts_toml(artifacts_toml) | |
return quote | |
# Invalidate .ji file if Artifacts.toml file changes | |
Base.include_dependency($(artifacts_toml)) | |
# Use invokelatest() to introduce a compiler barrier, preventing many backedges from being added | |
# and slowing down not only compile time, but also `.ji` load time. This is critical here, as | |
# artifact"" is used in other modules, so we don't want to be spreading backedges around everywhere. | |
Base.invokelatest(do_artifact_str, $(esc(name)), $(artifact_dict), $(artifacts_toml), $__module__) | |
end | |
end |
Turns out there is no 1.3.2. |
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
==========================================
+ Coverage 93.30% 94.27% +0.97%
==========================================
Files 32 32
Lines 1613 1607 -6
==========================================
+ Hits 1505 1515 +10
+ Misses 108 92 -16
Continue to review full report at Codecov.
|
A couple more changes needed: TimeZones.jl/src/tzdata/download.jl Lines 4 to 9 in 0e67ab1
TimeZones.jl/src/winzone/WindowsTimeZoneIDs.jl Lines 56 to 61 in 0e67ab1
|
Co-authored-by: Curtis Vogt <[email protected]>
This reverts commit 84b351b.
Co-authored-by: Curtis Vogt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. I've identified a few more things we can clear out due to dropping Julia 1.0 (e.g. tzdata_download
and friends) but I can tackle that in another PR.
Co-authored-by: Curtis Vogt <[email protected]>
Co-authored-by: Curtis Vogt <[email protected]>
else | ||
download(WINDOWS_ZONE_URL, xml_file) | ||
end | ||
download(WINDOWS_ZONE_URL, xml_file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just notice this is backwards. Will address
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops my bad.
Co-authored-by: Curtis Vogt <[email protected]>
As discussed in #354 raising min version to 1.3 will let use InlineStrings.jl