Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch space invaders on space #44

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

LilithHafner
Copy link
Contributor

@LilithHafner LilithHafner commented Apr 13, 2024

When triage was discussing JuliaLang/julia#33875, we discussed the prevalence of keyboard soup scattered across the ecosystem where different packages use different "magic keys" to launch repl modes. @oscardssmith mentioned "you can even press space for space invaders"

While several closed-minded triagers assumed he was joking, the merits of this keybinding are quite apparent

  • Space is a clear mnemonic for space invaders
  • The space bar is conveniently located in the center of the widely used BÉPO keyboard layout, and has a large surface area for user convince
  • No self-respecting line of Julia code entered at the REPL begins with a space

This PR makes pressing space at an empty julia> prompt launch space invaders.

In theory, this could be implemented as a package extension with REPL. However, according to several peer reviewed studies (source), there is growing concern among the Julia community that compile and load times are getting too low. This has resulted in decreased operational readiness in sword fighting atop rolling chairs (c.f. https://xkcd.com/303/). In an effort to rectify the situation, I didn't bother implementing this as a package extension.

As for the file name, while ".jl" is a classic ending, I think we can all agree that " .jl" is a bad file name, so I picked something a little more plain.

Copy link

@oscardssmith oscardssmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@theogf
Copy link
Member

theogf commented Apr 16, 2024

Tested and approved!

@theogf theogf merged commit 1821e3a into JuliaWTF:🖐️ Apr 16, 2024
11 checks passed
@adrhill
Copy link
Collaborator

adrhill commented Apr 16, 2024

This needs a release asap!

Can we document it in the README? Maybe we don't need to, since it's such an intuitive feature in the first place.

@theogf
Copy link
Member

theogf commented Apr 16, 2024

@ericphanson
Copy link

ericphanson commented Apr 16, 2024

@kellertuer
Copy link

Oh, that is sad, then even .jl would not help for that file. Maybe 👾.jl then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants