Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support infoview auto-close #86

Closed
rish987 opened this issue Jul 5, 2021 · 3 comments
Closed

Support infoview auto-close #86

rish987 opened this issue Jul 5, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@rish987
Copy link
Collaborator

rish987 commented Jul 5, 2021

Currently, :quitting the last Lean buffer in a tab leaves the infoview dangling in a detached state. Instead, it should automatically close the associated infoview, and :close should leave it in a detached state.

This will likely involve including the set of associated windows as part of the Infoview object, adding/removing these windows on Lean file BufEnter/BufExit, and once the last such buffer is exited, this will trigger the infoview to close as well. We should also make it (dynamically) configurable per-infoview whether or not this autoclose happens, in case someone doesn't like this -- that is, some kind of pin function that keeps the infoview around even when no Lean buffers are open.

@rish987 rish987 added the enhancement New feature or request label Jul 5, 2021
@Julian
Copy link
Owner

Julian commented Jul 6, 2021

What is the user-facing functionality that this is trying to support? Is it not just #84?

The second part of this sounds like #43, or is it trying to say something different?

@rish987
Copy link
Collaborator Author

rish987 commented Jul 6, 2021

Ah yes this is a dupe of #43, my bad!

@rish987 rish987 closed this as completed Jul 6, 2021
@Julian
Copy link
Owner

Julian commented Jul 6, 2021

All good just making sure I wasn't missing something!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants