Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add page titles and metadata using react-helmet #84

Closed
wants to merge 2 commits into from
Closed

Add page titles and metadata using react-helmet #84

wants to merge 2 commits into from

Conversation

duci9y
Copy link
Collaborator

@duci9y duci9y commented Mar 10, 2020

Closes #76. WIP!

@duci9y duci9y self-assigned this Mar 10, 2020
controversial
controversial requested changes Mar 10, 2020
View reviewed changes
Copy link
Collaborator

@controversial controversial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base meta information should be updated in public/index.html in addition to in App.tsx.

client/src/App.tsx Show resolved Hide resolved
@duci9y duci9y temporarily deployed to tutv-issue-76-au0ie5dbqg0hrs6i April 13, 2020 20:25 Inactive
@duci9y duci9y marked this pull request as draft April 14, 2020 17:06
@duci9y duci9y closed this Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@controversial controversial controversial requested changes

Assignees

@duci9y duci9y

@controversial controversial

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update document metadata
2 participants
@duci9y @controversial