From 5f3df77c852f36224e3309a0384465c89169f7c3 Mon Sep 17 00:00:00 2001 From: Deepanshu Utkarsh Date: Mon, 9 Mar 2020 23:15:40 -0400 Subject: [PATCH 1/2] Add react-helmet with basic implementation --- client/src/App.tsx | 105 +++++++++++++++++++++++---------------------- package.json | 2 + yarn.lock | 36 +++++++++++++++- 3 files changed, 90 insertions(+), 53 deletions(-) diff --git a/client/src/App.tsx b/client/src/App.tsx index 8ce808fa..fa080e39 100644 --- a/client/src/App.tsx +++ b/client/src/App.tsx @@ -1,5 +1,6 @@ import React from 'react'; import { BrowserRouter as Router, Switch, Route, Link } from 'react-router-dom'; +import Helmet from 'react-helmet'; // Components for pages of the app import Home from './pages/Home'; @@ -12,59 +13,59 @@ import SignIn from './pages/SignIn'; const App: React.FC = () => { return ( - -
- + + +
+ - - - - - - - - - - - - - - - - - - - - - - - -
- + + + + + + + + + + + + + +
+ + ); }; diff --git a/package.json b/package.json index 4b3df34a..f068449d 100644 --- a/package.json +++ b/package.json @@ -9,6 +9,7 @@ "@types/node": "12.7.5", "@types/react": "^16.9.0", "@types/react-dom": "16.9.0", + "@types/react-helmet": "^5.0.15", "@types/react-router-dom": "^5.1.0", "@types/react-tabs": "^2.3.1", "@typescript-eslint/eslint-plugin": "^2.2.0", @@ -54,6 +55,7 @@ "react-dev-utils": "^9.1.0", "react-dom": "^16.9.0", "react-feather": "^2.0.3", + "react-helmet": "^5.2.1", "react-router-dom": "^5.1.2", "react-styleguidist": "^9.1.16", "react-tabs": "^3.1.0", diff --git a/yarn.lock b/yarn.lock index bffb5d83..4b96b67b 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1352,6 +1352,13 @@ dependencies: "@types/react" "*" +"@types/react-helmet@^5.0.15": + version "5.0.15" + resolved "https://registry.yarnpkg.com/@types/react-helmet/-/react-helmet-5.0.15.tgz#af0370617307e9f062c6aee0f1f5588224ce646e" + integrity sha512-CCjqvecDJTXRrHG8aTc2YECcQCl26za/q+NaBRvy/wtm0Uh38koM2dpv2bG1xJV4ckz3t1lm2/5KU6nt2s9BWg== + dependencies: + "@types/react" "*" + "@types/react-router-dom@^5.1.0": version "5.1.2" resolved "https://registry.yarnpkg.com/@types/react-router-dom/-/react-router-dom-5.1.2.tgz#853f229f1f297513c0be84f7c914a08b778cfdf5" @@ -8921,7 +8928,7 @@ prompts@^2.0.1: kleur "^3.0.3" sisteransi "^1.0.3" -prop-types@^15.5.0, prop-types@^15.6.2, prop-types@^15.7.2: +prop-types@^15.5.0, prop-types@^15.5.4, prop-types@^15.6.2, prop-types@^15.7.2: version "15.7.2" resolved "https://registry.yarnpkg.com/prop-types/-/prop-types-15.7.2.tgz#52c41e75b8c87e72b9d9360e0206b99dcbffa6c5" integrity sha512-8QQikdH7//R2vurIJSutZ1smHYTcLpRWEOlHnzcWHmBYrOGUysKwSsrC89BCiFj3CbrfJ/nXFdJepOVrY1GCHQ== @@ -9197,6 +9204,11 @@ react-error-overlay@^6.0.3: resolved "https://registry.yarnpkg.com/react-error-overlay/-/react-error-overlay-6.0.3.tgz#c378c4b0a21e88b2e159a3e62b2f531fd63bf60d" integrity sha512-bOUvMWFQVk5oz8Ded9Xb7WVdEi3QGLC8tH7HmYP0Fdp4Bn3qw0tRFmr5TW6mvahzvmrK4a6bqWGfCevBflP+Xw== +react-fast-compare@^2.0.2: + version "2.0.4" + resolved "https://registry.yarnpkg.com/react-fast-compare/-/react-fast-compare-2.0.4.tgz#e84b4d455b0fec113e0402c329352715196f81f9" + integrity sha512-suNP+J1VU1MWFKcyt7RtjiSWUjvidmQSlqu+eHslq+342xCbGTYmC0mEhPCOHxlW0CywylOC1u2DFAT+bv4dBw== + react-feather@^2.0.3: version "2.0.3" resolved "https://registry.yarnpkg.com/react-feather/-/react-feather-2.0.3.tgz#1453ff5d8c242f72b8c02846118fbd2d406375ad" @@ -9211,6 +9223,16 @@ react-group@^3.0.0: dependencies: prop-types "^15.7.2" +react-helmet@^5.2.1: + version "5.2.1" + resolved "https://registry.yarnpkg.com/react-helmet/-/react-helmet-5.2.1.tgz#16a7192fdd09951f8e0fe22ffccbf9bb3e591ffa" + integrity sha512-CnwD822LU8NDBnjCpZ4ySh8L6HYyngViTZLfBBb3NjtrpN8m49clH8hidHouq20I51Y6TpCTISCBbqiY5GamwA== + dependencies: + object-assign "^4.1.1" + prop-types "^15.5.4" + react-fast-compare "^2.0.2" + react-side-effect "^1.1.0" + react-icons@^3.7.0: version "3.8.0" resolved "https://registry.yarnpkg.com/react-icons/-/react-icons-3.8.0.tgz#229de5904809696c9f46932bd9b6126b2522866e" @@ -9262,6 +9284,13 @@ react-router@5.1.2: tiny-invariant "^1.0.2" tiny-warning "^1.0.0" +react-side-effect@^1.1.0: + version "1.2.0" + resolved "https://registry.yarnpkg.com/react-side-effect/-/react-side-effect-1.2.0.tgz#0e940c78faba0c73b9b0eba9cd3dda8dfb7e7dae" + integrity sha512-v1ht1aHg5k/thv56DRcjw+WtojuuDHFUgGfc+bFHOWsF4ZK6C2V57DO0Or0GPsg6+LSTE0M6Ry/gfzhzSwbc5w== + dependencies: + shallowequal "^1.0.1" + react-simple-code-editor@^0.9.7: version "0.9.15" resolved "https://registry.yarnpkg.com/react-simple-code-editor/-/react-simple-code-editor-0.9.15.tgz#59e3583832e9e98992d3674b2d7673b4cd1c5709" @@ -10064,6 +10093,11 @@ shallow-clone@^3.0.0: dependencies: kind-of "^6.0.2" +shallowequal@^1.0.1: + version "1.1.0" + resolved "https://registry.yarnpkg.com/shallowequal/-/shallowequal-1.1.0.tgz#188d521de95b9087404fd4dcb68b13df0ae4e7f8" + integrity sha512-y0m1JoUZSlPAjXVtPPW70aZWfIL/dSP7AFkRnniLCrK/8MDKog3TySTBmckD+RObVxH0v4Tox67+F14PdED2oQ== + shebang-command@^1.2.0: version "1.2.0" resolved "https://registry.yarnpkg.com/shebang-command/-/shebang-command-1.2.0.tgz#44aac65b695b03398968c39f363fee5deafdf1ea" From 6f8874803b3f5cdea9450a4bf3857ffd2b64cf61 Mon Sep 17 00:00:00 2001 From: Deepanshu Utkarsh Date: Mon, 13 Apr 2020 16:23:01 -0400 Subject: [PATCH 2/2] Add helmet stuff to index.html as well --- client/public/index.html | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/client/public/index.html b/client/public/index.html index b2e8eafb..d3927e2c 100644 --- a/client/public/index.html +++ b/client/public/index.html @@ -7,7 +7,9 @@