Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't run pip install in setup.py #1318

Closed
boegel opened this issue Aug 13, 2024 · 2 comments
Closed

don't run pip install in setup.py #1318

boegel opened this issue Aug 13, 2024 · 2 comments
Assignees
@dineshbaburam91
Labels
Status: On Hold

Comments

@boegel
Copy link

boegel commented Aug 13, 2024

In the latest release of junos-eznc (2.7.1), the setup.py script includes a pip install command that is executed via os.system:

https://github.com/Juniper/py-junos-eznc/blob/2.7.1/setup.py#L6

This is quite nasty, as it can mess up people's Python environment very easily.
@boegel boegel mentioned this issue Aug 13, 2024
Merged
@chidanandpujar
Copy link
Collaborator

chidanandpujar commented Sep 3, 2024 •
edited
Loading

This change was introduced as part of #1299 #1299

@dineshbaburam91 dineshbaburam91 self-assigned this Oct 14, 2024
@dineshbaburam91
Copy link
Collaborator

Fixed #1342. Hence closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dineshbaburam91 dineshbaburam91

Labels
Status: On Hold
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@boegel @dineshbaburam91 @chidanandpujar