Improve planning logic for link modifications in apstra_datacenter_generic_system resource
#1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismarget-j
changed the title
r/generic_system less likely to destroy/create on link changer/generic_system less likely to destroy/create on link change
chrismarget-j
changed the title
r/generic_system less likely to destroy/create on link changeapstra_datacenter_generic_system resource
|
Closes #1041 |
chrismarget-j
requested review from
rajagopalans
and removed request for
rajagopalans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
resourceDatacenterGenericSystem.ModifyPlan(). It exists to trigger replacement of the generic system if the user has replaced or changed the speed of every link. A single surviving link will allow the system to be updated in place.Changes in this PR:
DatacenterGenericSystem.links()->DatacenterGenericSystem.GetLinks()(make public)DatacenterGenericSystemLink.digest()->DatacenterGenericSystemLink.Digest()(make public)DatacenterGenericSystem.UpdateLinkSet()now collects links with transform ID changes and replaces them one-at-a-timeDatacenterGenericSystem.UpdateLinkSet()now invokesdeleteLinksFromSystem()beforeaddLinksToSystem()(order swapped) to accommodate changes which may involve the same physical resource. For example, you can't add a link toxe-0/0/0before deleting the link toge-0/0/0because the use the same physical connectorgenericSystemLinkSetValidatornow checks forunknownvalues - minor change but looks like a big diff because large chunks of code "bumped" to the right because they're within theunknowncheck.resourceDatacenterGenericSystem.ModifyPlan()