Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Language specific reindentation #20

Open
3 tasks
aminya opened this issue Apr 5, 2020 · 7 comments
Open
3 tasks

[Feature] Language specific reindentation #20

aminya opened this issue Apr 5, 2020 · 7 comments

Comments

@aminya
Copy link
Contributor

aminya commented Apr 5, 2020

  • Usually, different grammars have different indent settings. Show that as one of the items in the selector with the name "Language's default setting".
  • When the detection is done, we can just compare it to what is set in Atom's Language's default setting, and offer to reindent (previous issue) with that setting.
  • Have a checkmark for always reindent for some specific language.

#19

@aviatesk
Copy link
Member

aviatesk commented Apr 5, 2020

Atom has that by default: https://flight-manual.atom.io/using-atom/sections/basic-customization/#language-specific-configuration-settings

@aviatesk aviatesk closed this as completed Apr 5, 2020
@aminya
Copy link
Contributor Author

aminya commented Apr 5, 2020

Nice. But this is in line with the previous feature. In case the indent used is different, we can offer to change it.

@aminya

This comment has been minimized.

@aviatesk
Copy link
Member

aviatesk commented Apr 5, 2020

sorry what do you mean by "the previous feature" ?

@aminya

This comment has been minimized.

@aviatesk
Copy link
Member

aviatesk commented Apr 5, 2020

Still I don't see why we should offer language-specific indent setting. Isn't enough to respect Atom's core functionality ?

@aviatesk aviatesk reopened this Apr 5, 2020
@aminya
Copy link
Contributor Author

aminya commented Apr 5, 2020

This isn't going to do anything against that but it will use it.

When the detection is done, we can just compare it to what is set in Atom's settings, and offer to reindent (previous issue) with that setting.

@aminya aminya changed the title [Feature] Language specific indent settings [Feature] Language specific reindentation Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants