You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! Thank you for all the hard work in this library! 👍
I discovered that this library is using exactly the same paths for chrome binaries as chrome-aws-lambda ( https://github.com/alixaxel/chrome-aws-lambda/blob/master/source/index.js#L166 ). This makes using both libraries in the same lambda a bit cumbersome. I would like to suggest putting the inflated binaries in a directory, for example /tmp/playwright-aws-lambda/chromium, or adding a prefix to the names.
I would be glad to help with a PR to tackle this issue 😃 .
A bonus thing that is present in chrome-aws-lambda, and missing in this library is the ability to await on executablePath (currently I have to inflate the files manually if I don't want to launch the browser).
The text was updated successfully, but these errors were encountered:
This is a great find! Thank you for raising this issue. I agree with the idea of adding the project name and browser type to the file path (/tmp/playwright-aws-lambda/chromium). I think that makes the most sense. I thin we'd want to major version this package afterward because it's unclear whether others are actively leveraging that exact path at runtime.
Hi! Thank you for all the hard work in this library! 👍
I discovered that this library is using exactly the same paths for chrome binaries as chrome-aws-lambda ( https://github.com/alixaxel/chrome-aws-lambda/blob/master/source/index.js#L166 ). This makes using both libraries in the same lambda a bit cumbersome. I would like to suggest putting the inflated binaries in a directory, for example
/tmp/playwright-aws-lambda/chromium
, or adding a prefix to the names.I would be glad to help with a PR to tackle this issue 😃 .
A bonus thing that is present in
chrome-aws-lambda
, and missing in this library is the ability to await onexecutablePath
(currently I have to inflate the files manually if I don't want to launch the browser).The text was updated successfully, but these errors were encountered: