Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid path conflicts with chrome-aws-lambda #14

Open
jan-osch opened this issue Jul 20, 2020 · 1 comment
Open

Avoid path conflicts with chrome-aws-lambda #14

jan-osch opened this issue Jul 20, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@jan-osch
Copy link

jan-osch commented Jul 20, 2020

Hi! Thank you for all the hard work in this library! 👍

I discovered that this library is using exactly the same paths for chrome binaries as chrome-aws-lambda ( https://github.com/alixaxel/chrome-aws-lambda/blob/master/source/index.js#L166 ). This makes using both libraries in the same lambda a bit cumbersome. I would like to suggest putting the inflated binaries in a directory, for example /tmp/playwright-aws-lambda/chromium, or adding a prefix to the names.

I would be glad to help with a PR to tackle this issue 😃 .

A bonus thing that is present in chrome-aws-lambda, and missing in this library is the ability to await on executablePath (currently I have to inflate the files manually if I don't want to launch the browser).

@austinkelleher
Copy link
Contributor

This is a great find! Thank you for raising this issue. I agree with the idea of adding the project name and browser type to the file path (/tmp/playwright-aws-lambda/chromium). I think that makes the most sense. I thin we'd want to major version this package afterward because it's unclear whether others are actively leveraging that exact path at runtime.

@austinkelleher austinkelleher added the enhancement New feature or request label Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants