Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onRetryAttempt doesn't handle promise rejection #119

Open
ScottChapman opened this issue Jul 3, 2020 · 0 comments · May be fixed by #244
Open

onRetryAttempt doesn't handle promise rejection #119

ScottChapman opened this issue Jul 3, 2020 · 0 comments · May be fixed by #244

Comments

@ScottChapman
Copy link

So, following the example for an async onRetryError, I decide to not retry is errno === "ENOTFOUND" (kinda no point, right?)

So, I call my reject function. But I always get an UnhandledPromisRejectionWarning on those.

So it looks like there is no catch block for those?
orgads added a commit to orgads/retry-axios that referenced this issue Dec 20, 2023
@orgads
fix: Call onRetryAttempt *after* backoff timeout
a27b34d 
The log appears before the timeout, which is misleading.

Also return support for async onRetryAttempt.

Fixes JustinBeckwith#119.
@orgads orgads linked a pull request Dec 20, 2023 that will close this issue
Open
orgads added a commit to orgads/retry-axios that referenced this issue Dec 20, 2023
@orgads
fix: Call onRetryAttempt *after* backoff timeout
12ce1c8 
The log appears before the timeout, which is misleading.

Also return support for async onRetryAttempt.

Introduce a new onError callback that is called before the timeout.

Fixes JustinBeckwith#119.
orgads added a commit to orgads/retry-axios that referenced this issue Dec 20, 2023
@orgads
fix: Call onRetryAttempt *after* backoff timeout
cbb5f41 
The log appears before the timeout, which is misleading.

Also return support for async onRetryAttempt.

Introduce a new onError callback that is called before the timeout.

Fixes JustinBeckwith#119.
orgads added a commit to orgads/retry-axios that referenced this issue Jun 13, 2024
@orgads
fix: Call onRetryAttempt *after* backoff timeout
f7325e6 
The log appears before the timeout, which is misleading.

Also return support for async onRetryAttempt.

Introduce a new onError callback that is called before the timeout.

Fixes JustinBeckwith#119.
orgads added a commit to orgads/retry-axios that referenced this issue Jun 13, 2024
@orgads
fix: Call onRetryAttempt *after* backoff timeout
6ca787a 
The log appears before the timeout, which is misleading.

Also return support for async onRetryAttempt.

Introduce a new onError callback that is called before the timeout.

Fixes JustinBeckwith#119.
orgads added a commit to orgads/retry-axios that referenced this issue Jun 13, 2024
@orgads
fix: Call onRetryAttempt *after* backoff timeout
f633719 
The log appears before the timeout, which is misleading.

Also return support for async onRetryAttempt.

Introduce a new onError callback that is called before the timeout.

Fixes JustinBeckwith#119.
orgads added a commit to orgads/retry-axios that referenced this issue Jun 13, 2024
@orgads
fix: Call onRetryAttempt *after* backoff timeout
04e032e 
The log appears before the timeout, which is misleading.

Also return support for async onRetryAttempt.

Introduce a new onError callback that is called before the timeout.

Fixes JustinBeckwith#119.
orgads added a commit to orgads/retry-axios that referenced this issue Jun 13, 2024
@orgads
fix: Call onRetryAttempt *after* backoff timeout
70ce6ed 
The log appears before the timeout, which is misleading.

Also return support for async onRetryAttempt.

Introduce a new onError callback that is called before the timeout.

Fixes JustinBeckwith#119.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Call onRetryAttempt *after* backoff timeout orgads/retry-axios
1 participant
@ScottChapman