Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change truncation strategy to always select smallest schmidt coefficient #188

Merged
merged 2 commits into from
Dec 13, 2024
Merged

change truncation strategy to always select smallest schmidt coefficient #188

merged 2 commits into from
Dec 13, 2024

Conversation

Jutho
Copy link
Owner

@Jutho Jutho commented Dec 13, 2024 •
edited
Loading

Addresses #184

@codecov Codecov
Copy link

codecov bot commented Dec 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.95%. Comparing base (9f553b0) to head (6a0a3bc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/tensors/truncation.jl 50.00% 4 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #188   +/-   ##
=======================================
  Coverage   82.95%   82.95%           
=======================================
  Files          42       42           
  Lines        5223     5223           
=======================================
  Hits         4333     4333           
  Misses        890      890

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lkdvos
lkdvos approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lkdvos lkdvos linked an issue Dec 13, 2024 that may be closed by this pull request
Why using weighted singular values for the truncation? #184
Closed
@lkdvos lkdvos merged commit 48413d2 into master Dec 13, 2024
13 of 14 checks passed
@lkdvos lkdvos deleted the jh/changetruncation branch December 13, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkdvos lkdvos lkdvos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why using weighted singular values for the truncation?
2 participants
@Jutho @lkdvos