Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local extensions are kinda broken (low priority) #42

Open
faddix opened this issue Nov 2, 2024 · 3 comments
Open

Local extensions are kinda broken (low priority) #42

faddix opened this issue Nov 2, 2024 · 3 comments

Comments

@faddix
Copy link

faddix commented Nov 2, 2024

Describe the bug
Local extensions require a lot of restarting to work properly.

To Reproduce
First of all, when enabling local extensions and going to the the apposite tab the extensions won't show up. To make them show, you have to restart the program (this only happens if you go to the local extension tab before enabling the option in the settings, apparently).

Once you do download an extension, the program will still say "you have no extensions installed" when trying to click on any anime. To solve this, once again, you have to restart the program.
In other words, to make any new extension work you have to restart the program.

After installing the extension if you go back to the local extensions tab and try to uninstall one (that has been installed before restarting the app, to make it actually work) it will throw out three failed to bind errors and will remove (not completely) the extension.
To remove the extension completely, for the third time, you have to restart the program.

Expected behavior
The program works without having to restart it.

Screenshots
Extensions not showing up: immagine
Bind errors:
immagine

Desktop (please complete the following information):

  • OS: Windows 11
  • Version: 101.0.22631 build 22631
@K3vinb5
Copy link
Owner

K3vinb5 commented Nov 2, 2024

Hummmm, I digged around for a while and discovered that this happens on windows because it doesn't kill the sub process like the code says too, I use linux and there it works as expected, I have thought of a solution and will implement it then. Besides this trouble with restarting what do you think about the local extensions? I'm looking for feedback because once they are pretty usable I'll discontinue the server.

@K3vinb5
Copy link
Owner

K3vinb5 commented Nov 2, 2024

Another question, this bind exceptions got fixed when you restart the app on this last version right? And also, thank you so much for opening an issue and contributing with feedback only that way can this project evolve, it's been kinda dead lately because I started a new job and my personal pc got screwed and I've been having very few free time.

@faddix
Copy link
Author

faddix commented Nov 3, 2024

Apart from this problem, local extensions sometimes don't work when opening the program (lets you open the anime but episodes won't load, restart required to fix).
Also, the program sometimes won't start (infinite loading, this usually happens after restarting a bunch of times, usually fixes itself after restarting it a couple more times).

As for the feedback, I think local extensions work fine aside from the issues mentioned, it usually takes about 1GB or less of RAM when playing videos and having the possibility to remove the sources you don't use is a nice feature.

I really like this program, but there are some gimmick that I can't do without, like resuming where you left or one click to play (saving the last source provider and its resolution).
Other than that, let me know if you need any more feedback.

Edit 2: I read the question wrong my bad, yes the bind exception got fixed when restarting on the last version, I'm not sure whether or not it would've fixed it in the previous version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants