Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong preallocation of d_voxelZeroCross #10

Open
grungeguitarist opened this issue Dec 16, 2022 · 0 comments
Open

Wrong preallocation of d_voxelZeroCross #10

grungeguitarist opened this issue Dec 16, 2022 · 0 comments

Comments

@grungeguitarist
Copy link

grungeguitarist commented Dec 16, 2022

Since d_voxelZeroCross is a list of (zero-crossing) voxels (and not voxel blocks), it should be allocated with the size...
'sizeof(int3) * params.m_numSDFBlocks * params.m_SDFBlockSize * params.m_SDFBlockSize * params.m_SDFBlockSize'
and not...
'sizeof(int3) * params.m_hashNumBuckets * 2'.

This allocation happens in VoxelUtilHashSDF.h (while it is filled in findZeroCrossingVoxelsKernel(...) in CUDATexUpdate.cu).

Otherwise, it could crash with an illegal memory access exception when processing larger scenes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant