-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "substitute path" option #612
Comments
maybe I misunderstand it, but can't you use a sysroot for that purpose? i.e. just create the mirrored directory structure and then point to that as sysroot? |
You are right that this works and it also works around the root needing a symlink. I'd say the sysroot option is the perfect workaround (not sure that all parts included source lookup uses that, but at least it should). But a sysroot needs to be complete, no? If yes than this would mean creating even more symlinks and in any case it is more work (creating the directories, then create the symlinks in there) than just specifying one substitute. |
I don't follow. A sysroot needs to be just as complete as your substitute? I mean if you substitute I'm not saying I don't like the idea of a substitute, but it feels like a super minor thing that you can easily handle with the sysroot already. If you want to work on adding this feature, I'm happy to review patches. But I don't see the need for that myself yet. |
Sounds fair. I totally agree that this makes no sense for substituting |
normally you just need |
Is your feature request related to a problem? Please describe.
I currently work on a customer performance check. We have a machine that "nearly matches" what the customer has and get actual quite good results in HotSpot already, but for those we have to setup symlinks to exactly match the paths on the customer machine (thge recording has the full path of the libraries in)
Describe the solution you'd like
Provide
--substitutePath A:B
option for perfparser + hotspot (similar to what GDB offers for source, we can analyze coredumps that way), then later optionally a GUI configuration.Describe alternatives you've considered
What we currently do:
Additional context
The substitutePath would be used for both binaries and source mappings.
The text was updated successfully, but these errors were encountered: