Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phrase_freqs.tab not found #216

Open
yoshiask opened this issue Oct 25, 2023 · 2 comments
Open

phrase_freqs.tab not found #216

yoshiask opened this issue Oct 25, 2023 · 2 comments

Comments

@yoshiask
Copy link

Describe the bug
The dictionary_reader.py utility attempts to load a file named phrase_freqs.tab, which does not exist in the repo (or anywhere else as far as I can tell).

To Reproduce
Steps to reproduce the behavior:

  1. Clone repository
  2. Run dictionary_reader.py from any directory
  3. See error:
o Reading ./xml/Comprehensive_Coptic_Lexicon-v1.2-2020.xml
Traceback (most recent call last):
  File "/mnt/c/Users/jjask/source/repos/KELLIA/dictionary/./utils/dictionary_reader.py", line 612, in <module>
    data = io.open("phrase_freqs.tab", encoding="utf8").read().strip().split("\n")
FileNotFoundError: [Errno 2] No such file or directory: 'phrase_freqs.tab'

Expected behavior
The phrase_freqs.tab file should be provided in the repo, or if this is not possible, the dependency should be documented and made optional.

Additional context
I'm only trying to use the utility because parsing the XML source at the start of my program is too costly, and the checked-in [alpha_kyima_rc1.db](https://github.com/KELLIA/dictionary/blob/master/alpha_kyima_rc1.db) is four years out of date. It might be worth updating the DB if you can't provide the missing file for the utility. I can open a separate issue for this if requested.

@yoshiask
Copy link
Author

Just realized it's available in the dev branch. This issue can be closed.

@amir-zeldes
Copy link
Member

Thanks for reporting - we should probably put out a new stable release and pull dev to master. I'll leave this open as a reminder and hope we can find some time to do that before long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants