Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the use of programs, default to p7zip on unix #9

Open
v3natio opened this issue Sep 26, 2024 · 1 comment
Open

Reduce the use of programs, default to p7zip on unix #9

v3natio opened this issue Sep 26, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@v3natio
Copy link

v3natio commented Sep 26, 2024

As the title suggests, most operations can be done using the 7z command. Archiving as zip, or tar doesn't require those commands.

E.g.

# compress into tar
7z a -ttar test.tar test_1.toml test_2.toml ...
# compress into zip
7z a -ttar test.zip test_1.toml test_2.toml ...

Let me know if there's a specific reason, or cons to this approach. Otherwise I'm happy to contribute a PR.

@v3natio v3natio changed the title Reduce the use of programs, default to p7zip on unix. Reduce the use of programs, default to p7zip on unix Sep 26, 2024
@KKV9
Copy link
Owner

KKV9 commented Sep 26, 2024

I think the code can be simplified using this approach. Features such as password-protected archives will be easier to implement, though at the expense of creating an additional dependency for Unix users. If possible, consider keeping the initial Unix options as a backup for those who do not have p7zip installed. We can fully deprecate them at a later stage. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants