Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/#101 #102

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Issue/#101 #102

merged 5 commits into from
Sep 26, 2024

Conversation

kwonssshyeon
Copy link
Member

@kwonssshyeon kwonssshyeon commented Sep 25, 2024

๐Ÿ”Ž ์ž‘์—… ๋‚ด์šฉ

  • ๋ฆฌ๋ทฐ ์ž‘์„ฑ์‹œ ์„ฑ์ทจ๋„, ๋‚œ์ด๋„ ์ถ”๊ฐ€
  • ๋ฆฌ๋ทฐ ์กฐํšŒ์‹œ ์„ฑ์ทจ๋„, ๋‚œ์ด๋„, ์ž‘์„ฑ์ผ์ž ์ถ”๊ฐ€

์ด๋ฏธ์ง€ ์ฒจ๋ถ€

To Reviewers ๐Ÿ“ข

flyway์— alter ์ฟผ๋ฆฌ 2๊ฐœ๊ฐ€ ์ž˜ ๋™์ž‘ํ•˜๋Š”๊ฑด์ง€ ๋ชฐ๋ฅด๊ฒ ์–ด์š” ...
์„ฑ์ทจ๋„๋ž‘ ๋‚œ์ด๋„ ํ•„๋“œ๋Š” not null์ด์–ด์„œ int๋กœ ๋‘˜๊นŒํ•˜๋‹ค๊ฐ€ ๊ทธ๋ž˜๋„ null๋Œ€์‹  0์ด ๋“ค์–ด๊ฐ€๋Š”๋ฐ ์˜๋ฏธ์ƒ ์•ˆ๋งž๋‹ค๊ณ  ์ƒ๊ฐํ•ด์„œ Integer๋กœ ๋’€์Šต๋‹ˆ๋‹ค.

์ฒดํฌ ๋ฆฌ์ŠคํŠธ

  • ํ…Œ์ŠคํŠธ๋ฅผ ์ž‘์„ฑํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ํ…Œ์ŠคํŠธ๋ฅผ ํ†ต๊ณผํ–ˆ์Šต๋‹ˆ๋‹ค.
  • API ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์กด์žฌํ•ฉ๋‹ˆ๋‹ค.
  • API ํ˜ธ์ถœ์„ ์ง์ ‘ ์‹ค์‹œํ•˜์˜€๊ณ , ํ•ด๋‹น ๋ฐ์ดํ„ฐ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ํ‘œ์‹œ๋ฉ๋‹ˆ๋‹ค.
  • ๊ธฐ์กด ์ฝ”๋“œ์— ์˜ํ–ฅ์„ ์ฃผ๋Š” ์ž‘์—… ๋‚ด์šฉ์ด ์กด์žฌํ•ฉ๋‹ˆ๋‹ค.
  • ํ–ฅํ›„ ์ถ”๊ฐ€์ ์ธ ์ž‘์—…์ด ํ•„์š”ํ•œ ๋ถ€๋ถ„์ด ์žˆ์Šต๋‹ˆ๋‹ค.

โž• ๊ด€๋ จ ์ด์Šˆ

Copy link

github-actions bot commented Sep 25, 2024

Unit Test Results

33 testsโ€‚โ€ƒโ€ƒ33 โœ”๏ธโ€ƒโ€ƒ2s โฑ๏ธ
11 suitesโ€ƒโ€ƒโŸโ€„0 ๐Ÿ’ค
11 filesโ€„โ€‚โ€ƒโ€ƒโŸโ€„0 โŒ

Results for commit 7fd153d.

โ™ป๏ธ This comment has been updated with latest results.

โ€ฆd_column_review.sql

Co-authored-by: ์†ํ™์„ <[email protected]>
@bayy1216 bayy1216 merged commit b1f534d into main Sep 26, 2024
3 checks passed
@bayy1216 bayy1216 deleted the issue/#101 branch September 26, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants