Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/#86 #91

Merged
merged 7 commits into from
Sep 10, 2024
Merged

Issue/#86 #91

merged 7 commits into from
Sep 10, 2024

Conversation

momnpa333
Copy link
Collaborator

๐Ÿ”Ž ์ž‘์—… ๋‚ด์šฉ

์ด๋ฏธ์ง€ ์ฒจ๋ถ€

To Reviewers ๐Ÿ“ข

  • ์ฑŒ๋ฆฐ์ง€ ๊ทธ๋ฃน ๊ด€๋ จ api response ์ˆ˜์ •
  • ์ฑŒ๋ฆฐ์ง€ ๊ทธ๋ฃน ์ˆํผ ์กฐํšŒ์™€ ๋ˆ„์ ์ฐธ์—ฌ์ž ์ˆ˜ ๋ถˆ๋Ÿฌ์˜ค๋Š” ๋กœ์ง ๊ตฌํ˜„ ํ•„์š”

์ฒดํฌ ๋ฆฌ์ŠคํŠธ

  • ํ…Œ์ŠคํŠธ๋ฅผ ์ž‘์„ฑํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ํ…Œ์ŠคํŠธ๋ฅผ ํ†ต๊ณผํ–ˆ์Šต๋‹ˆ๋‹ค.
  • API ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์กด์žฌํ•ฉ๋‹ˆ๋‹ค.
  • API ํ˜ธ์ถœ์„ ์ง์ ‘ ์‹ค์‹œํ•˜์˜€๊ณ , ํ•ด๋‹น ๋ฐ์ดํ„ฐ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ํ‘œ์‹œ๋ฉ๋‹ˆ๋‹ค.
  • ๊ธฐ์กด ์ฝ”๋“œ์— ์˜ํ–ฅ์„ ์ฃผ๋Š” ์ž‘์—… ๋‚ด์šฉ์ด ์กด์žฌํ•ฉ๋‹ˆ๋‹ค.
  • ํ–ฅํ›„ ์ถ”๊ฐ€์ ์ธ ์ž‘์—…์ด ํ•„์š”ํ•œ ๋ถ€๋ถ„์ด ์žˆ์Šต๋‹ˆ๋‹ค.

โž• ๊ด€๋ จ ์ด์Šˆ

Copy link

Unit Test Results

32 testsโ€‚โ€ƒโ€ƒ32 โœ”๏ธโ€ƒโ€ƒ2s โฑ๏ธ
โŸโ€„9 suitesโ€ƒโ€ƒโŸโ€„0 ๐Ÿ’ค
โŸโ€„9 filesโ€„โ€‚โ€ƒโ€ƒโŸโ€„0 โŒ

Results for commit 6450f87.

Copy link
Collaborator

@bayy1216 bayy1216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@momnpa333 momnpa333 merged commit 44fb89a into main Sep 10, 2024
3 checks passed
@momnpa333 momnpa333 deleted the issue/#86 branch September 10, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI์— ๋งž์ถ”์–ด ์ฑŒ๋ฆฐ์ง€๊ทธ๋ฃน api ์ˆ˜์ •
2 participants