Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full (Optional) Github Integration #70

Closed
jkoritzinsky opened this issue Feb 18, 2016 · 6 comments
Closed

Full (Optional) Github Integration #70

jkoritzinsky opened this issue Feb 18, 2016 · 6 comments

Comments

@jkoritzinsky
Copy link

One feature that would be awesome for SpaceDock would be to have full GitHub integration for people who want to use it. I want to stress that this would be a totally optional feature for people to use. Below were some of the features I was thinking of:

  • OAuth login via GitHub: People could log in via GitHub like how on other sites people can log in via Google, Twitter, Facebook, etc.
  • "Import Mod from GitHub": Show a list of the users GitHub repositories and have them select which repositories to pull releases from a la Github integration #33.
  • Pull requests like the old KerbalStuff-Bot tied to the user: Have the PRs sent for the mods be sent by the user's GitHub profile instead of the replacement of KerbalStuff-Bot.

This would make it much easier for people who traditionally deploy their mods on GitHub to switch to SpaceDock.

@GenPage GenPage added Type: Improvement Area: Backend Related to the Python code that runs inside gunicorn Type: Question labels Feb 18, 2016
@Olympic1 Olympic1 added this to the SpaceDock 1.0 "Phoenix" milestone Feb 19, 2016
@avivey
Copy link

avivey commented Feb 19, 2016

OAuth login via GitHub

I've implemented that about 2 weeks ago, in the KS's last pr KerbalStuff/KerbalStuff#129 - just requires activation...

@avivey
Copy link

avivey commented Feb 19, 2016

Another possible integration: if a mod is tied to a GitHub repo, it's possible to have the official download link download directly from GH - savings in bandwidth/disk.

@jkoritzinsky
Copy link
Author

I'd be all for pulling the download from GH directly if it can. Saves on the bandwidth costs for SpaceDock.

@godarklight
Copy link

I think @V1TA5 has reasons against wanting to use OAuth for login - as he wants to keep everything on his own server, it also complicates dealing with user accounts on spacedock somewhat, but I'm not sure by how much.

That being said, a one click "Import mod from github" does sound nice for those who use github releases when first setting up spacedock, although they'd have to mark which version of KSP each mod is for, which is something that is likely going to break ;)

@jkoritzinsky
Copy link
Author

If @V1TA5 could chime in with why he doesn't want to use OAuth, I'd love to hear the reasoning. Since the code is already implemented and just needs to be surfaced to the user, it can't be that hard to do.

And the marking of the KSP versions can be done the same way we GitHub mod creators have always done it, manually. Same as CKAN.

Also, note that the only way to do the "Import" button as one button with auto-updating releases is with the GitHub webhooks, which either requires people manually configuring them (definitely not user friendly), or having an OAuth token to do so (at which point, might as well go the whole way). If the import is not auto-updating, then there really isn't a point to having the import, because then it's just manual dual hosting all over again.

@StollD StollD removed this from the SpaceDock 1.0 "Phoenix" milestone Mar 3, 2016
@DasSkelett DasSkelett modified the milestone: next public release May 21, 2020
@HebaruSan
Copy link
Contributor

  • OAuth allegedly already implemented in code, just not enabled on site, so no coding needed there
  • Copying releases from GitHub is a duplicate of Github integration #33 and another issue isn't needed to track the same thing
  • The CKAN pull request work flow works fine as-is with the @netkan-bot submitting them, not clear what value would be added by changing the submitter

Closing as no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants