-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full (Optional) Github Integration #70
Comments
I've implemented that about 2 weeks ago, in the KS's last pr KerbalStuff/KerbalStuff#129 - just requires activation... |
Another possible integration: if a mod is tied to a GitHub repo, it's possible to have the official download link download directly from GH - savings in bandwidth/disk. |
I'd be all for pulling the download from GH directly if it can. Saves on the bandwidth costs for SpaceDock. |
I think @V1TA5 has reasons against wanting to use OAuth for login - as he wants to keep everything on his own server, it also complicates dealing with user accounts on spacedock somewhat, but I'm not sure by how much. That being said, a one click "Import mod from github" does sound nice for those who use github releases when first setting up spacedock, although they'd have to mark which version of KSP each mod is for, which is something that is likely going to break ;) |
If @V1TA5 could chime in with why he doesn't want to use OAuth, I'd love to hear the reasoning. Since the code is already implemented and just needs to be surfaced to the user, it can't be that hard to do. And the marking of the KSP versions can be done the same way we GitHub mod creators have always done it, manually. Same as CKAN. Also, note that the only way to do the "Import" button as one button with auto-updating releases is with the GitHub webhooks, which either requires people manually configuring them (definitely not user friendly), or having an OAuth token to do so (at which point, might as well go the whole way). If the import is not auto-updating, then there really isn't a point to having the import, because then it's just manual dual hosting all over again. |
Closing as no longer needed. |
One feature that would be awesome for SpaceDock would be to have full GitHub integration for people who want to use it. I want to stress that this would be a totally optional feature for people to use. Below were some of the features I was thinking of:
This would make it much easier for people who traditionally deploy their mods on GitHub to switch to SpaceDock.
The text was updated successfully, but these errors were encountered: