Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

ActivateNextStage fails in 1.1.x #62

Open
listrophy opened this issue May 10, 2016 · 7 comments
Open

ActivateNextStage fails in 1.1.x #62

listrophy opened this issue May 10, 2016 · 7 comments

Comments

@listrophy
Copy link

It seems as though ActivateNextStage does nothing. I've tried in 1.1.1 and 1.1.2. I can change throttle, so something is obviously working, but staging simply does not work.

@binary1230
Copy link

+1'ing this, just noticed this too in trying to launch a rocket from the pad. might investigate looking into how to fix this if it's a simple thing.

I 'worked around' this (in the dumbest way possible) by:

  • turn on infinite fuel
  • Settings action group 1 to 'activate engine' and use that instead of staging

@binary1230
Copy link

oh hey just noticed your PR, neat.

@tcannonfodder
Copy link
Member

This has been fixed in my version of Telemachus: https://github.com/tcannonfodder/Telemachus

@woutervddn
Copy link

Can someone verify that this merge request works as expected?

Seems like some other files need to be added.. I might try it myself later tonight.

@woutervddn
Copy link

@tcannonfodder then why don't push the changes upstream?

@binary1230
Copy link

I did recompile this myself with the fix and it does work. It looks like adding this fix, and recompiling against the new KSP version, makes everything in the mod work that I (quickly and not very thoroughly) tested. Some parts of the current official release didn't work for me, like web graphs display page, but started working after a recompile against the latest KSP

Would be cool to get an official release, barring that, I was thinking about doing some kind of unofficial interm release that works against KSP1.1 and has this fix in it.

@tcannonfodder
Copy link
Member

hey @woutervddn and @binary1230 I made a release here: https://github.com/tcannonfodder/Telemachus/releases/tag/v1.5.33

@binary1230 I'm working on getting a new, actively maintained version of Telemachus off the ground. If you'd like to help as a maintainer, that would be awesome. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants