Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selene tries to update with an explicit path in Settings.json #375

Open
Kontoury opened this issue Jun 12, 2022 · 2 comments · May be fixed by #585
Open

Selene tries to update with an explicit path in Settings.json #375

Kontoury opened this issue Jun 12, 2022 · 2 comments · May be fixed by #585
Labels
A-vscode Area: Visual Studio Code extension C-bug Category: Bug E-easy Call for participation: Experience needed to fix: Easy / not much

Comments

@Kontoury
Copy link

This should be pretty low priority because of the easy fix.

Reproduction steps:

  • Download and unzip Selene 0.18.1 or lower
  • Set up the Selene path in VSCode
  • Restart VSCode
    You should be getting the notification asking to update Selene.

To fix, simply remove the Path from Settings.json
@Kampfkarren Kampfkarren added C-bug Category: Bug A-vscode Area: Visual Studio Code extension E-easy Call for participation: Experience needed to fix: Easy / not much labels Jun 12, 2022
@akai54
Copy link

akai54 commented Feb 20, 2023

Hello,
I would like to take care of this if it's possible.
If anyone can give me an advice on where to start, and which files I should be checking, it would be awesome.

@Kampfkarren Kampfkarren mentioned this issue Feb 20, 2023
Closed
@Kampfkarren
Copy link
Owner

@akai54 The VSCode extension code is pretty crappy right now, but here's what you'd do:

selene/selene-vscode/src/util.ts

Lines 164 to 169 in 085532a

return getLatestSeleneRelease()
.then((release) => {
if (version !== `selene ${release.tag_name}`) {
openUpdatePrompt(storagePath, release)
}
})

This is the code that checks for updates.

This is the code for checking an explicit version:

selene/selene-vscode/src/util.ts

Lines 130 to 132 in 085532a

const settingPath = vscode.workspace
.getConfiguration("selene")
.get<string | null>("selenePath")

Ideally the first block of code wouldn't be where it is, but that's where it is right now unfortunately. You would wrap that return with the same check for if the setting isn't set.

@Midnightific Midnightific linked a pull request Feb 5, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-vscode Area: Visual Studio Code extension C-bug Category: Bug E-easy Call for participation: Experience needed to fix: Easy / not much
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix explicit settings path Midnightific/selene
3 participants
@Kampfkarren @akai54 @Kontoury