From 2f62113c9a989c72eb8b9225b8ea9bbfcc75497e Mon Sep 17 00:00:00 2001 From: islxyqwe Date: Wed, 31 Jan 2024 17:57:46 +0800 Subject: [PATCH 1/2] chore: update graphic walker --- packages/rath-client/package.json | 2 +- yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/rath-client/package.json b/packages/rath-client/package.json index 4ceb7ddf..fc4ea36d 100644 --- a/packages/rath-client/package.json +++ b/packages/rath-client/package.json @@ -16,7 +16,7 @@ "@fluentui/react-file-type-icons": "^8.8.3", "@fluentui/react-hooks": "^8.6.11", "@fluentui/react-icons": "^2.0.200", - "@kanaries/graphic-walker": "^0.4.47", + "@kanaries/graphic-walker": "^0.4.50", "@kanaries/loa": "^0.0.16", "@kanaries/web-data-loader": "0.1.7", "@vercel/analytics": "^1.0.0", diff --git a/yarn.lock b/yarn.lock index 45b745a6..eb8335f4 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3956,10 +3956,10 @@ dependencies: localforage "^1.10.0" -"@kanaries/graphic-walker@^0.4.47": - version "0.4.47" - resolved "https://registry.yarnpkg.com/@kanaries/graphic-walker/-/graphic-walker-0.4.47.tgz#bf4f0a1396153ecd62e401d2bb5cc7c7eb5c57db" - integrity sha512-VPByjpsTFPoAaEqwX/L/cRM7ut5QtWYRSjec2j83T2hRULk1ntb8flGYgVB6zrHIwfHvrI3/puiF5Pq9X8917Q== +"@kanaries/graphic-walker@^0.4.50": + version "0.4.50" + resolved "https://registry.npmmirror.com/@kanaries/graphic-walker/-/graphic-walker-0.4.50.tgz#b117f41b8c16c3cca305d3280b28b0dcd3ebf4a3" + integrity sha512-KVwtsCgCQJbJ37GvEvk+JMIAaZPIdIUhoAtLwLtA7R59HslHwHCtvdByaJhhNvxRfydfn+BEpZ525JDd2sZflA== dependencies: "@headlessui-float/react" "^0.11.4" "@headlessui/react" "1.7.12" From 2d9e4a6eee2aac5f3deda8f08f7650ed06b5c1e2 Mon Sep 17 00:00:00 2001 From: islxyqwe Date: Wed, 27 Mar 2024 11:33:44 +0800 Subject: [PATCH 2/2] fix: fix painter bugs --- packages/rath-client/src/App.css | 1 - packages/rath-client/src/pages/painter/index.tsx | 5 +++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/rath-client/src/App.css b/packages/rath-client/src/App.css index 35b5a3e6..f417b595 100644 --- a/packages/rath-client/src/App.css +++ b/packages/rath-client/src/App.css @@ -112,7 +112,6 @@ h2, h3 { .main-app-container{ display: flex; - overflow: auto; position: fixed; /* top: 60px; */ top:0px; diff --git a/packages/rath-client/src/pages/painter/index.tsx b/packages/rath-client/src/pages/painter/index.tsx index 0ef54b6f..dbc25bab 100644 --- a/packages/rath-client/src/pages/painter/index.tsx +++ b/packages/rath-client/src/pages/painter/index.tsx @@ -123,6 +123,7 @@ const Painter: React.FC = (props) => { }, 800), [painterStore]) const noViz = viewData.length === 0 || fieldMetas.length === 0 || vizSpec === null; + const axisResizable = painterMode === PAINTER_MODE.MOVE; const painterSpec = useMemo(() => { if (!noViz) { const mvd: any = { @@ -140,7 +141,7 @@ const Painter: React.FC = (props) => { domain: mutFeatValues, }, }; - if (painterMode === PAINTER_MODE.MOVE) { + if (axisResizable) { if (!(mvd.params instanceof Array)) { mvd.params = []; } @@ -153,7 +154,7 @@ const Painter: React.FC = (props) => { return mvd; } return null; - }, [vizSpec, mutFeatValues, noViz, painterMode]); + }, [vizSpec, mutFeatValues, noViz, axisResizable]); const [realPainterSize, setRealPainterSize] = useState(0); useEffect(() => { if (painterSpec !== null && container.current) {