Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gif.js git dependency problematic for codesandbox and CI services #1816

Open
FWeinb opened this issue Jan 15, 2020 · 1 comment
Open

gif.js git dependency problematic for codesandbox and CI services #1816

FWeinb opened this issue Jan 15, 2020 · 1 comment

Comments

@FWeinb
Copy link
Contributor

FWeinb commented Jan 15, 2020

It would be great if this library could be used on codesandbox.io to get started quickly and for sharing.

Currently you are using a git+ssh reference to the gif.js library here:

kano-code/package.json

Line 84 in 8944a63

"gif.js": "git+ssh://[email protected]:jnordberg/gif.js.git",

codesandbox.io isn't able to resolve that:
image

This could possible be an issue for using CI services too.
@FWeinb FWeinb mentioned this issue Jan 15, 2020
Open
@pazdera
Copy link
Contributor

pazdera commented Jan 17, 2020

Found this today which includes some extra bits over the original npm package: https://www.npmjs.com/package/gif.js-upgrade

Maybe we could switch out the dependency and see what happens?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pazdera @FWeinb