Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Song Validation and Rating #1

Open
TheMcs000 opened this issue Dec 8, 2021 · 2 comments
Open

Song Validation and Rating #1

TheMcs000 opened this issue Dec 8, 2021 · 2 comments
Labels
proposal A Karman feature proposal status/draft A proposal that is still being drafted
Milestone

Comments

@TheMcs000
Copy link

TheMcs000 commented Dec 8, 2021

In my opinion the following feature is essential and might have a severe impact on the file structure. Therefore I suggest that we address it in an early stage:

Karman should also have a possibility to save whether or not a song is "good" or rather "tested".
This way you could upload your current song library / give external users access to upload songs without worrying too much which songs are good enough.

Furthermore this way the work of testing songs can be split up, since everyone with a browser (and permissions) could test the song and it's not depending on one user who might have a lot of songs he/she wants to upload.

In addition to that I would wish for two ways to check this status:

  1. A list of trusted persons / administrators who are allowed to set the state of a song (done, needs attention, unplayable, ...)
  2. A rating system where anybody could give a 1-5 star rating and maybe a comment on what could be approved.

On how we track broken songs, see #6

The point, which makes it file structure breaking, would be my proposal, that the file state should somehow be reflected in the file structure. This way you could easily download only the "good songs".

Furthermore a history of all edits / state changes should be saved. However, this implementation should be easy

@TheMcs000 TheMcs000 mentioned this issue Dec 8, 2021
@TheMcs000
Copy link
Author

Implementation idea:

  • karman has one big directory containing all its files (with a cryptic name so songs with the same name / versions can exist)
  • There will be stable, unclear, ... folders with different versions of songs.
    • In these folders the files will be sym-linked to the main file in the big main directory from karman

@TheMcs000
Copy link
Author

TheMcs000 commented Dec 15, 2021

From #3: I would suggest more details to the verification. I would some kind of state and maybe multiple users could set different states or approve states from other people? This needs more thought...

@codello codello added the proposal A Karman feature proposal label Dec 21, 2021
@codello codello added this to the Version 0.1 milestone Dec 21, 2021
@codello codello added the status/draft A proposal that is still being drafted label Dec 25, 2021
@codello codello changed the title Missing song validation Song Validation and Rating Dec 25, 2021
@codello codello modified the milestones: Version 0.1, Version 0.2 Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal A Karman feature proposal status/draft A proposal that is still being drafted
Projects
None yet
Development

No branches or pull requests

2 participants