Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publicly available APIs #5

Open
TheMcs000 opened this issue Dec 8, 2021 · 2 comments
Open

Publicly available APIs #5

TheMcs000 opened this issue Dec 8, 2021 · 2 comments
Labels
proposal A Karman feature proposal status/draft A proposal that is still being drafted
Milestone
Version 0.2

Comments

@TheMcs000
Copy link

By the current concept the API is publicly available.
Due to copyright concerns I would suggest that we restrict the publicly available APIs to the song titles, artists and maybe artwork.

I think we should discuss this...
@TheMcs000
Copy link
Author

MafiA Star relevante Dinge sollten öfftl. zugänglich sein.
Cover, Songtext sollte nur verfügbar sein, wenn man angemeldet ist.

Für Vers. 1: Alles erstmal hinter login

Für Später: Server betreiber sollte aussuchen wie viel nach außen verfügbar sein sollte

@codello codello changed the title Public available APIs Publicly available APIs Dec 15, 2021
@codello codello added this to the Version 0.1 milestone Dec 15, 2021
@codello codello mentioned this issue Dec 15, 2021
Closed
@codello codello added proposal A Karman feature proposal status/draft A proposal that is still being drafted labels Dec 21, 2021
@codello codello modified the milestones: Version 0.1, Version 0.2 Sep 1, 2023
@codello codello mentioned this issue Sep 2, 2023
Merged
@codello
Copy link
Contributor

codello commented Sep 2, 2023

#51 adds support for this in the API spec. The PR marks some endpoints as potentially publicly available. Additionally there should be some kind of setting to control this on a per-deployment basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal A Karman feature proposal status/draft A proposal that is still being drafted
Projects
None yet
Milestone
Version 0.2
Development

Successfully merging a pull request may close this issue.

Add notes about permissions Karaoke-Manager/karman
2 participants
@codello @TheMcs000