You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are a bunch of functions with weird, ambiguos and/or bad names. This is an issue I will never close, because I think these kind of bad names will never end. Just link the PR that address these kind of issues here, and describe in your PR what are you attending to fix. Below is a list of function names I will take note and you can take as example to refactor.
[ ] (run_wrapper)[https://github.com/KarlHeitmann/rg_explorer/blob/960bf90942896f78eee3eaf327e4fbf30b19235c/src/rip_grep/mod.rs#L93]: I introduced run_wrapper when I added the feature to edit the search_term of RipGrep struct by the src/ui/edit.rs ui. The idea was to wrap the run inside a wrapper. run function will perform the rg child process and update the Nodes of the RipGrep struct. But I don't wanted run to be called if the search_term didn't change at all. That's why I wrapped it into the run_wrapper function, run_wrapper will only execute run if search term is different than the search_term_buffer, the String that is manipulated on src/ui/edit.rs. Maybe someone has an idea for a better name to run_wrapper ? or this is unnecesary/overwhelming?
The text was updated successfully, but these errors were encountered:
There are a bunch of functions with weird, ambiguos and/or bad names. This is an issue I will never close, because I think these kind of bad names will never end. Just link the PR that address these kind of issues here, and describe in your PR what are you attending to fix. Below is a list of function names I will take note and you can take as example to refactor.
[ ] (run_wrapper)[https://github.com/KarlHeitmann/rg_explorer/blob/960bf90942896f78eee3eaf327e4fbf30b19235c/src/rip_grep/mod.rs#L93]: I introduced
run_wrapper
when I added the feature to edit the search_term ofRipGrep
struct by thesrc/ui/edit.rs
ui. The idea was to wrap the run inside a wrapper.run
function will perform therg
child process and update theNodes
of theRipGrep
struct. But I don't wantedrun
to be called if the search_term didn't change at all. That's why I wrapped it into therun_wrapper
function,run_wrapper
will only executerun
if search term is different than thesearch_term_buffer
, the String that is manipulated onsrc/ui/edit.rs
. Maybe someone has an idea for a better name torun_wrapper
? or this is unnecesary/overwhelming?The text was updated successfully, but these errors were encountered: