SliverWithPinnedFooter #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR. However I notice that when I use it with a reversed list, the list rendered area shrink when I scroll through multiple sections with SliverWithPinnedFooter. Not to mention that the footer is still at the bottom of the section, although it should be on top (I did fix that by changing the paint method). device-2023-05-12-153632.mp4Any idea how I could fix the shrinking? |
TomBursch
reviewed
Jan 2, 2024
| offset.dy + | ||
| geometry.paintOrigin + | ||
| geometry.paintExtent - | ||
| footer.size.height, |
There was a problem hiding this comment.
To fix the footer appearing first, line 99 should be replaced with min(footer.size.height, geometry.paintExtent) (same for the hitTest)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of a first attempt at making a
SliverPinnedFooter.TODO:
Closes #20