Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Could I PR for SliverClipRRect? #38

Open
AlexanderFarkas opened this issue Dec 2, 2021 · 2 comments
Open

Could I PR for SliverClipRRect? #38

AlexanderFarkas opened this issue Dec 2, 2021 · 2 comments
Assignees
@AlexanderFarkas
Labels
enhancement New feature or request question Further information is requested
Projects
sliver_tools

Comments

@AlexanderFarkas
Copy link

Also, I propose to rename SliverClip to SliverClipRect to align with Flutter naming for Box-based widgets.
@Kavantix
Copy link
Owner

Kavantix commented Dec 2, 2021

Hi @AlexanderFarkas yeah sure that would be very welcome

I do want SliverClip to stay though at least for now, but feel free to add an alias SliverClipRect as well.
Perhaps all of them can be statelesswidgets that give different paths to SliverClip or something like that

@Kavantix Kavantix added the question Further information is requested label Dec 2, 2021
@Kavantix Kavantix added this to To do in sliver_tools via automation Dec 2, 2021
@Kavantix Kavantix added the enhancement New feature or request label Dec 2, 2021
@Kavantix
Copy link
Owner

Kavantix commented Jan 4, 2022

@AlexanderFarkas did you manage to make some progress?
Feel free to open a Draft PR if you need any help/advice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexanderFarkas AlexanderFarkas

Labels
enhancement New feature or request question Further information is requested
Projects
sliver_tools
Status: To do
sliver_tools
  
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kavantix @AlexanderFarkas