Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It will be support for Nette 3 ? #306

Closed
misaon opened this issue Oct 16, 2017 · 18 comments
Closed

It will be support for Nette 3 ? #306

misaon opened this issue Oct 16, 2017 · 18 comments

Comments

@misaon
Copy link

misaon commented Oct 16, 2017

No description provided.

@enumag
Copy link
Member

enumag commented Oct 16, 2017

At the moment it seems that Nettrine might be ready sooner than Kdyby is updated.

@f3l1x
Copy link

f3l1x commented Jan 6, 2018

At this moment we're trying to prepare MVP of Nettrine ORM + DBAL. It definitely takes a lot of time to at the same level as Kdyby, but we're not creating clone of Kdyby. I would rather name it as minimal must-have integration of Doctrine to Nette. Maybe with some extra stuff around.

It would be great to join us a set expectations of the MVP.

@f3l1x
Copy link

f3l1x commented May 1, 2018

Nettrine ORM and DBAL has some stable releases, we're still working on new features. At this time it is fully working integration used on many projects. Don't hesitate to take a look or help us to improve it.

@haltuf
Copy link
Contributor

haltuf commented Jun 4, 2019

I'm going to TRY to prepare PR for Nette v3.0 compatibility.
Anyone wishing to help me with this, please contact me.

@vojta001
Copy link

For those finding this issue: Nette 3.0 compatibility was added in #330 and we are currently waiting for a release.

@krkabol
Copy link

krkabol commented Jan 12, 2020

Hi, is there some progress about the Nette 3.0 compatible release? Or is something that we can help with?

@enumag
Copy link
Member

enumag commented Jan 12, 2020

@krkabol See this comment for the reason why I didn't tag it yet #330 (comment)

@freiondrej
Copy link

@enumag is the kdyby/console dependency a deal breaker? Now that PHP 8 is almost there, nette 3.0 is a must-have, because nette 2.4 is not compatible with PHP 8 (according to https://nette.org/en/maintenance#toc-php-compatibility).

@enumag
Copy link
Member

enumag commented Oct 9, 2020

At this point I think I have to reconsider. I still dislike the dependency but then again Kdyby is mostly dead by now. It won't hurt to have a Nette 3.0 compatible release for the legacy applications. Although long-term wise you should consider a migration to Contributte and Nettrine.

@enumag
Copy link
Member

enumag commented Oct 9, 2020

For anyone who wants a release, please send a PR to add PHP 7.4 into .travis.yml. If 8.0 is available on travis then I'd recommend adding it as well.

@enumag
Copy link
Member

enumag commented Oct 9, 2020

Also #334 should likely be finished as well. I can't merge it because it's failing though.

@f3l1x
Copy link

f3l1x commented Oct 9, 2020

Although long-term wise you should consider a migration to Contributte and Nettrine.

Thanks @enumag. Contributte/Nettrine has active and growing community, I would also offer my to help to anyone with migration.

@darkWolf-PR
Copy link

Although long-term wise you should consider a migration to Contributte and Nettrine.

Thanks @enumag. Contributte/Nettrine has active and growing community, I would also offer my to help to anyone with migration.

I´ve tried Nettrine conversion few months ago on small website build with kdyby/doctrine(for who know what reason...) and it was hell of a problem, had to make changes to almost every php file in it. We have larger system running for dozen or more clients with nette 2.3 and kdyby/doctrine and that would make me rewrite hundreds of files, it would take months to get everything working. Months no one would give me for that...

Not mention many problems with Nettrine documentation and demos running different versions, contradicting each other with configuration etc.

@enumag
Copy link
Member

enumag commented Nov 3, 2020

I don't have personal experience with Nettrine so I don't know how good their documentation and demos are. However unlike Kdyby it's still very active much more likely to fix bugs and docs.

If your codebase requires that much rewriting from Kdyby to Nettrine then I believe you have a much bigger problem. Your codebase should be dependent on Doctrine but preferably not on a particular Nette integration. So my recommendation is to first refactor your codebase to be less tied to Kdyby (= don't write new features that way and gradually refactor the old ones) and when it's in better state, try migrating to Nettrine again. Btw. are you sure that most of the things to change isn't a simple matter of bulk regex replace in phpstorm?

@darkWolf-PR
Copy link

Yeah, I know...and no one cares, so I can do pretty much jackshit...no one give me months to rewrite all the crap, whose author is about 3-4? years gone... It´s not tied only to Kdyby/Doctrine, there was a lot of other stuff locking updating. like Grido in backend locking everything on Nette 2.3 and php 7.0 for example. It´s basically a vicious circle between component versions(variants) and php versions that ensures that only way to update/switch is update/switch everything at once, which would take months... It´s not starting version, it was build on something like php 5.2-5.3, I´m pretty sure parts were build with Nette 2.0 beta x. It was already hell of a fight to get everything working on or be compatible with php 7 instead of 5.x as that at least made whole system work a bit faster.

@f3l1x
Copy link

f3l1x commented Nov 4, 2020

I am sorry for your codebase :(

We can ask @TomasVotruba, if there is a way to use rector to migrate from kdyby to contributte + nettrine.

@TomasVotruba
Copy link
Contributor

@f3l1x Depends how many people would use it.
If you can get me the diffs with small code samples, we should be able to add such set.

@fmasa
Copy link

fmasa commented Nov 6, 2020

We are currently migrating one project from Kdyby\Doctrine to Nettrine\Dbal + custom ORM integration as well. For us the biggest pain points are new and tweaked EntityRepository methods for Kdyby. Otherwise it would be easy to do a simple replace.

@misaon misaon closed this as completed Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants