The most frequently done mistakes being done while raising a PR! #141
Keerat666
announced in
Announcements
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The most similar mistake that some people are doing while contributing to the repo is not following the proper folder structure. The solutions are correct but some of the contributors are just adding it to the root folder and raising a PR.
I appreciate the effort for contributing to the repo, but the defined folder structure has to be strictly followed so that the repository remains easily navigable and finding the solution to an existing Leetcode problem remains super easy!
For example, if you solved leetcode problem number 123 and it is marked as easy
Then the folder path in which the solution should be pushed is :
Secondly, please do not raise a PR for a problem if you haven't created an issue for it. Raising an issue would enable other people also to share their implementation for the problem and that is the whole point of this repo, which is to get multiple solutions for a solo problem in various languages.
The PR won't be merged until either of these issues are not fixed.
Beta Was this translation helpful? Give feedback.
All reactions