Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add points filter & checkboxes #61

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dom-elves
Copy link

Adds a simple points filter to the task list.

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for myroutebuddy ready!

Name Link
🔨 Latest commit 4af48d0
🔍 Latest deploy log https://app.netlify.com/sites/myroutebuddy/deploys/6746f28d4320010008fb9fa3
😎 Deploy Preview https://deploy-preview-61--myroutebuddy.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KennethLuczko
Copy link
Owner

@dom-elves I like this, but can you make it so that by default, all tasks show?

You can have a checkbox with "Show All" and have it pre-filled.

The user can then un-check "Show All" and then check whatever point option they want (10, 30, and so on).

@dom-elves
Copy link
Author

@KennethLuczko Haven't managed to get it so boxes are checked by default. Vue behaves strangely if you have a checkbox bound to a data property, you lose the ability to just add the html checked property to make a checkbox be checked by default. Though I suppose I could just do that on mount. This binding issue did seem to lead me to a bit of trouble with getting the logic right when it came to the case of "if some checkboxes aren't checked, check them", haven't managed to figure out a way to compare the checked with unchecked boxes without disrupting the current use of v-bind.

Did however manage to add a computed property that should just add more checkboxes relative to task points when Jagex update their API tomorrow!

@KennethLuczko
Copy link
Owner

Gotcha, my only concern is that a user would not be able to intuitively tell how to get tasks to show up.

@dom-elves
Copy link
Author

Possible, though unlikely I'm gonna have much time to look into it now, not until next week at least!

@KennethLuczko
Copy link
Owner

Possible, though unlikely I'm gonna have much time to look into it now, not until next week at least!

No worries, going to keep it open for the meanwhile, once it's added we can rebase and merge

@dom-elves
Copy link
Author

Found the time, could do with a refactor but at least it's working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants