Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atto don't like multilang2 #5

Closed
sberger opened this issue Dec 5, 2019 · 6 comments
Closed

Atto don't like multilang2 #5

sberger opened this issue Dec 5, 2019 · 6 comments

Comments

@sberger
Copy link

sberger commented Dec 5, 2019

If multilang2 is activated in the settings of the Atto editor (toolbar config editor_atto | toolbar -> multilang2 = multilang2), certain javascript-based actions will no longer work, such as the drag & drop area for file upload or drop-down menus (tested in moodle 3.8).
This happens even if the filter itself is disabled. The reason seems to be the inclusion in the Atto toolbar.
Installed versions are:

  • Multi-Language Content (v2) filter_multilang2 | 1.1.1 | 2019111900
  • Multi-Language Content (v2) atto_multilang2 | master - Release v1.11.2 (Build 2019112700) for Moodle 3.6, 3.7 and 3.8 | 2019112700
  • Moodle 3.8 (Build: 20191118)

with_multilang2_in_atto

without_multilang2_in_atto

@lucaboesch
Copy link

lucaboesch commented Dec 5, 2019

Thanks for the report, Stefanie!
Luckily I don't have this in my Moodle 3.6.7…!
The steps to reproduce as above are: Enable editing mode in your course, then 'Add an activity or resource' of type 'File', right?

I've got the button included not as multilang2=multilang2 but in line with other. And in a different order probably. Would you mind trying that out on your site?

collapse = collapse
style1 = title,bold,italic,bfhfontcolor,bfhbackcolor
list = unorderedlist,orderedlist
links = link
files = image, media, recordrtc, managefiles
style2 = underline,strike,subscript,superscript
align = align
indent = indent
insert = equation,charmap,table,clear,emoticon,embedquestion
undo = undo
accessibility = accessibilitychecker,accessibilityhelper
other = html,multilang2,fullscreen,cloze,kalturamedia

Best,
Luca

@sberger
Copy link
Author

sberger commented Dec 5, 2019

The steps to reproduce as above are: Enable editing mode in your course, then 'Add an activity or resource' of type 'File', right?

Yes, it was the way ...

And I'm sorry, it's the same with:
....
insert = equation, charmap, table, emoticon
undo = undo
accessibility = accessibilitychecker, accessibilityhelper
other = rtl, multilang2

Even the menu of the Atto-Mutilang2 filter can't be closed.

Bildschirmfoto 2019-12-05 um 11 26 03

@izendegi
Copy link

izendegi commented Dec 5, 2019

Hi there,

I haven't been able to reproduce this issue either, but it seems like it's related to some old issues that were fixed here.

@sberger , can you tell us if you're using some other non-standard plugins (atto plugins, theme...) on that site that come into conflict with atto_multilang2?

@sberger
Copy link
Author

sberger commented Dec 5, 2019

yes, of course, it's my test moodle :-)
Here is the list of additional plugins:

Visioex – Moodle 3 8_ Administration_ Plugins_ Plugins overview

@KepaUrzelai
Copy link
Owner

Hi everyone,

I have reproduced the issue adding the HTMLPlus plugin to my Moodle version 3.8 instance, so this is the one causing conflict with the Atto Multilang2 plugin.
The solution in this case is very easy because, since Moodle version 3.6, this plugin is standardized. This is to say that the functionalities of atto_htmplus plugin were incorporated into atto_html (see MDL-5177), so you just need to delete that first one.

I hope it helps.

@sberger
Copy link
Author

sberger commented Dec 5, 2019

You are right, without HTML+ the Multilang2 filter works without problems. Thank a lot!
Stefanie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants