Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should faiss be a requirement? #730

Open
sammlapp opened this issue Nov 5, 2024 · 1 comment
Open

should faiss be a requirement? #730

sammlapp opened this issue Nov 5, 2024 · 1 comment

Comments

@sammlapp
Copy link

sammlapp commented Nov 5, 2024

If faiss package is not installed, AccuracyCalculator() initialization raises NameError: name 'faiss' is not defined

@KevinMusgrave
Copy link
Owner

I set it up this way because the official faiss package is only available on conda. But I think lots of people use the unofficial pip package, so maybe I'll add it to the dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants