Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow string for device argument of AccuracyCalculator #737

Open
KevinMusgrave opened this issue Dec 21, 2024 · 1 comment
Open

Allow string for device argument of AccuracyCalculator #737

KevinMusgrave opened this issue Dec 21, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@KevinMusgrave
Copy link
Owner

Calling AccuracyCalculator(device="cpu") instead of AccuracyCalculator(device=torch.device("cpu")) crashes with an unclear exception (AttributeError: 'str' object has no attribute 'type').

It'd be better to check if isinstance(device, str), and then do device=torch.device(device)
@KevinMusgrave KevinMusgrave added the enhancement New feature or request label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KevinMusgrave and others