-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltip not closing - mouseEvent not fired #186
Comments
here are some more clarifications: The underlying library for the Tooltip is mantine/core and that uses Floating UI. The onOpenChange event is not fired in the scenario described above because it's lost during rerender The open state change is "correct" , but the onCange event is not fired. So it's not really a bug in the MRT, but I think the behavior could be improved by:
|
I've already solved this with managed state for the full screen button. Didn't realize that the sort tooltips needed this too |
Any plans to fix this or a workaround? |
I've ran into this too, example below looks to be corrected by re-hovering over the sortby icon. Strange one, would like to know what causes it. e.g. |
mantine-react-table version
v1.3.3
react & react-dom versions
v18.2.0
Describe the bug and the steps to reproduce it
The Tooltip for the Column sort button in the table head does not close. (applies also to search, column density..)
It is reproduceable actually on the Mantine React Table demo site as well, as seen in the screenshot below where the mouse pointer is hovering a row and the sorting tooltip is still there.
To reproduce it, you have to move the mouse pointer away quickly downwards after the click on the button.
Chain of events, what I suspect is happening:
Icon is hovered --> Tooltip appears
Icon is clicked --> Sorting order Label changes --> Tooltip stays
If now the mouse pointer is pulled away during the rerender, the Tooltip will stay permanently.
If the mouse pointer is moved away after the rerender is completed --> Tooltip goes away
I believe the way to improve it, would be to make the Tooltip disappear in the onclick event.
You guys are doing an amazing job !
Minimal, Reproducible Example - (Optional, but Recommended)
can be reproduced here for example, probably it gets easier to reproduce if table is a bit larger and rerender takes longer.
https://www.mantine-react-table.com/docs/guides/column-ordering-dnd
Screenshots or Videos (Optional)
Do you intend to try to help solve this bug with your own PR?
Maybe, I'll investigate and start debugging
Terms
The text was updated successfully, but these errors were encountered: