Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the issue #1111 #1116

Open
wants to merge 2 commits into
base: v2
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions apps/Untitled Diagram.drawio
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<mxfile host="app.diagrams.net" agent="Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/127.0.0.0 Safari/537.36" version="24.7.6">
<diagram name="Page-1" id="qXCI9F8pUE_jkJfL5WtS">
<mxGraphModel>
<root>
<mxCell id="0" />
<mxCell id="1" parent="0" />
</root>
</mxGraphModel>
</diagram>
</mxfile>
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ const fetchSize = 25;
const Example = () => {
const tableContainerRef = useRef<HTMLDivElement>(null); //we can get access to the underlying TableContainer element and react to its scroll events
const rowVirtualizerInstanceRef = useRef<MRT_RowVirtualizer>(null); //we can get access to the underlying Virtualizer instance and call its scrollToIndex method

const [currentMaxPages, setCurrentMaxPages] = useState(4);
const [columnFilters, setColumnFilters] = useState<MRT_ColumnFiltersState>(
[],
);
Expand Down Expand Up @@ -100,6 +100,7 @@ const Example = () => {
initialPageParam: 0,
getNextPageParam: (_lastGroup, groups) => groups.length,
refetchOnWindowFocus: false,
maxPages: currentMaxPages,
});

const flatData = useMemo(
Expand All @@ -110,6 +111,22 @@ const Example = () => {
const totalDBRowCount = data?.pages?.[0]?.meta?.totalRowCount ?? 0;
const totalFetched = flatData.length;

const handleScroll = useCallback(() => {
const containerElement = tableContainerRef.current;
if (containerElement) {
const { scrollHeight, scrollTop, clientHeight } = containerElement;

if (
scrollHeight - scrollTop - clientHeight < 400 &&
!isFetching &&
totalFetched < totalDBRowCount &&
currentMaxPages < totalDBRowCount / fetchSize
) {
setCurrentMaxPages((prevMaxPages) => prevMaxPages + 2);
}
}
}, [currentMaxPages, isFetching, totalFetched, totalDBRowCount]);

//called on scroll and possibly on mount to fetch more data as the user scrolls and reaches bottom of table
const fetchMoreOnBottomReached = useCallback(
(containerRefElement?: HTMLDivElement | null) => {
Expand Down Expand Up @@ -138,6 +155,16 @@ const Example = () => {
}
}, [sorting, columnFilters, globalFilter]);

useEffect(() => {
const containerElement = tableContainerRef.current;
if (containerElement) {
containerElement.addEventListener('scroll', handleScroll);
return () => {
containerElement.removeEventListener('scroll', handleScroll);
};
}
}, [handleScroll]);

//a check on mount to see if the table is already scrolled to the bottom and immediately needs to fetch more data
useEffect(() => {
fetchMoreOnBottomReached(tableContainerRef.current);
Expand Down