-
-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't double highlight nested tables #1197
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I'm not sure what caused "Clean PR" step above to fail. I wonder if it is unable to checkout my branch? My fork is public with no branch protection. I have no idea why it wouldn't be able to check out my branch. Any help would be greatly appreciated. |
Is there a screenshot of what the bug is? Table in a cell? |
The gray is the hover color. The dark gray happens when a nested table is inside a cell, very similar to the one I added to the storybook example. This is what I mean by table in a cell
I use a table in a cell to keep the text on one line with an ellipsis.
Thank you for the fast response. |
A table within a cell just to add an ellipsis is a weird solution. You should just be able to use any old div with the proper CSS to accomplish the same thing. |
The TableCel is double highlighted if there is a table in a cell. This pull request makes the highlight only apply to td's that are a direct child of tr.