-
-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Accessibility - captions #957
Conversation
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/caption > A caption functions like a heading for a table. Most screen readers announce the content of captions. Captions help users to find a table and understand what it’s about and decide if they want to read it. If the user uses “Tables Mode”, captions are the primary mechanism to identify tables. The caption is provided by the <caption> element. from: https://www.w3.org/WAI/tutorials/tables/caption-summary/
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I'm open to adding a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs types, and maybe it should be renderCaption
?
and we'll need to make a few storybook examples showing how to use this, and what it looks like |
Thanks for the quick response. I don't actually use TypeScript tho I think I can read through it well enough. I'm glad you support the idea. I can look into what would need to be added to make this compliant with the rest of the code base. If it is renderCaption, do you think it makes sense to have just a string? I was thinking of allowing JSX so that the caption could be visible only to screen readers with the addition of some css/style. This would probably be my own use case. |
I guess it could just be a string in |
nvm fixed it in the examples |
Thank you Kevin! I was going to look into making the updates you recommended this morning, but I see you have already fixed everything up. I greatly appreciate the effort! |
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/caption
from: https://www.w3.org/WAI/tutorials/tables/caption-summary/