-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bindings): Implement secondary store type responsible for managing App Gateway TLS Listener certificate bindings #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
m8rmclaren
commented
Feb 6, 2024
- Azure Application Gateway Orchestrator Extension v2.0.0
- feat(bindings): Implemented a second Command Certificate Store Type called AppGwBin that logically represents the binding of an Application Gateway SSL Certificate to a TLS Listener.
- feat(bindings): Removed TLS Listener binding logic from AzureAppGW certificate store type implementation.
- chore(client): Refactored client to prefer dependency injection pattern.
- chore(jobs): Refactored Orchestrator job implementations to prefer dependency injection pattern.
- chore(tests): Implemented unit testing framework with a fake client interface.
- chore(tests): Implemented integration tests for both Orchestrator jobs and App Gateway client.
…y-orchestrator into nullcert-53654 chore(rebase): Rebase nullcert-53654
…dingJobs, unit testing framework
…re-appgateway-orchestrator into bindings-54126
…re-appgateway-orchestrator into bindings-54126
…if environment is not set up properly
…re-appgateway-orchestrator into bindings-54126
m8rmclaren
added
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Feb 6, 2024
…re-appgateway-orchestrator into bindings-54126
…nd new store type name
fiddlermikey
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved by JC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.