Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Message signing; colon cuts off rest of message #1576

Open
its-DomeE opened this issue Jan 14, 2025 · 1 comment
Open

Bug: Message signing; colon cuts off rest of message #1576

its-DomeE opened this issue Jan 14, 2025 · 1 comment

Comments

@its-DomeE
Copy link

its-DomeE commented Jan 14, 2025

When trying to sign a message using the Sparrow Wallet, a colon character : will cut off the rest of the message and therefore doesn't create a valid signature.

In case of e.g. Pocket Bitcoin this will make the Keystone wallet not usable since you have to sign a message in the format of:
Ich bestaetige diese Bitcoin-Adresse alleine zu kontrollieren. Auftragsnummer: ffffffff

Other ASCII characters seem to work fine. I experimented a bit and commas, semicolon, etc. won't cut off a message. But a colon does.

Using firmware v1.8.2

@its-DomeE
Copy link
Author

The error seems to lie here:

let mut headers_and_message = value.split(":");
let headers = headers_and_message.next();
let message = headers_and_message.next();

The header is split from the message by a colon resulting in additional items which are not checked, if a colon is used inside the message. So maybe this would be resolved if using split_once instead of split?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant