Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coverage reports #370

Open
kevinbarabash opened this issue Apr 5, 2019 · 2 comments
Open

Fix coverage reports #370

kevinbarabash opened this issue Apr 5, 2019 · 2 comments
Labels
testing

Comments

@kevinbarabash
Copy link
Contributor

I'm not sure why coveralls is report 0% coverage. It might have to do with using @babel/register. I was thinking we might look at moving to jest which also produces coverage reports doesn't require @babel/register to run ES6. I was also thinking of maybe using codecov.io for tracking coverage as it provides reports inside PRs. I'm not sure if coveralls does that. The current coverage has been broken for a while so starting fresh doesn't seem so bad. https://coveralls.io/github/Khan/aphrodite?branch=master
@lencioni
Copy link
Collaborator

lencioni commented Apr 6, 2019

Big +1 on moving to jest.

@lencioni
Copy link
Collaborator

lencioni commented Apr 6, 2019

I think the snapshots would be a great fit for a lot of the current unit tests in particular.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lencioni @kevinbarabash