diff --git a/.eslintrc.js b/.eslintrc.js index 6ce8142e47..23a50d6994 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -309,10 +309,10 @@ module.exports = { /** * react */ - "react/no-string-refs": "off", // on in recommended, but #legacy-code - "react/no-find-dom-node": "off", // on in recommended, but #legacy-code - "react/display-name": "off", // on in recommended, but we have many components that don't have a displayName - "react/no-unescaped-entities": "off", // on in recommended, but #legacy-code + "react/no-string-refs": "off", // on in react/recommended, but we have #legacy-code + "react/no-find-dom-node": "off", // on in react/recommended, but we have #legacy-code + "react/display-name": "off", // on in react/recommended, but doesn't seem that useful to fix + "react/no-unescaped-entities": "off", // on in react/recommended, but we have #legacy-code // This rule results in false-positives when using some types of React // components (such as functional components or hooks). Since // TypeScript is already checking that components are only using props diff --git a/testing/ke-score-ui.tsx b/testing/ke-score-ui.tsx index 0a6b47366e..bae5942f53 100644 --- a/testing/ke-score-ui.tsx +++ b/testing/ke-score-ui.tsx @@ -8,7 +8,7 @@ type Props = { score: KEScore | null | undefined; }; -export default ({score}: Props): React.ReactElement | null => { +export default function KEScoreUI({score}: Props) { if (score == null) { return null; } @@ -46,4 +46,4 @@ export default ({score}: Props): React.ReactElement | null => { /> ); -}; +}