From 94cbc51027f944136aa224ea789b1acc438f7f73 Mon Sep 17 00:00:00 2001 From: Tamara Date: Thu, 12 Dec 2024 16:02:44 -0600 Subject: [PATCH] Remove unused rubric type --- packages/perseus/src/validation.types.ts | 7 ------- packages/perseus/src/widgets/cs-program/cs-program.tsx | 7 ++----- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/packages/perseus/src/validation.types.ts b/packages/perseus/src/validation.types.ts index 03f7139c7c..72daa455c6 100644 --- a/packages/perseus/src/validation.types.ts +++ b/packages/perseus/src/validation.types.ts @@ -63,12 +63,6 @@ export type PerseusCategorizerValidationData = { items: ReadonlyArray; }; -// TODO(LEMS-2440): Can possibly be removed during 2440? -// This is not used for grading at all. The only place it is used is to define -// Props type in cs-program.tsx, but RenderProps already contains WidgetOptions -// and is already included in the Props type. -export type PerseusCSProgramRubric = Empty; - export type PerseusCSProgramUserInput = { status: UserInputStatus; message: string | null; @@ -237,7 +231,6 @@ export type PerseusTableUserInput = ReadonlyArray>; export type Rubric = | PerseusCategorizerScoringData - | PerseusCSProgramRubric | PerseusDropdownRubric | PerseusExpressionRubric | PerseusGroupRubric diff --git a/packages/perseus/src/widgets/cs-program/cs-program.tsx b/packages/perseus/src/widgets/cs-program/cs-program.tsx index 1b60ef2159..317d829b9e 100644 --- a/packages/perseus/src/widgets/cs-program/cs-program.tsx +++ b/packages/perseus/src/widgets/cs-program/cs-program.tsx @@ -19,17 +19,14 @@ import scoreCSProgram from "./score-cs-program"; import type {PerseusCSProgramWidgetOptions} from "../../perseus-types"; import type {Widget, WidgetExports, WidgetProps} from "../../types"; -import type { - PerseusCSProgramRubric, - PerseusCSProgramUserInput, -} from "../../validation.types"; +import type {PerseusCSProgramUserInput} from "../../validation.types"; import type {UnsupportedWidgetPromptJSON} from "../../widget-ai-utils/unsupported-widget"; const {updateQueryString} = Util; type RenderProps = PerseusCSProgramWidgetOptions & PerseusCSProgramUserInput; -type Props = WidgetProps; +type Props = WidgetProps; type DefaultProps = { showEditor: Props["showEditor"];