Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update story to contain dollar sign #1870

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

anakaren-rojas
Copy link
Contributor

@anakaren-rojas anakaren-rojas commented Nov 15, 2024

Summary:

Add on to #1865 - updates story to include $

Issue: XXX-XXXX

Test plan:

@anakaren-rojas anakaren-rojas self-assigned this Nov 15, 2024
@khan-actions-bot khan-actions-bot requested a review from a team November 15, 2024 23:25
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Nov 15, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/nice-tips-ring.md, packages/perseus/src/widgets/interactive-graphs/interactive-graph-regression.stories.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (7de9528) and published it to npm. You
can install it using the tag PR1870.

Example:

yarn add @khanacademy/perseus@PR1870

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1870

Copy link
Contributor

Size Change: 0 B

Total Size: 1.29 MB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.9 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 77.8 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 699 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/index.js 420 kB
packages/perseus/dist/es/strings.js 3.55 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link
Member

@benchristel benchristel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@catandthemachines catandthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😉

Copy link
Member

@catandthemachines catandthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😉

@anakaren-rojas
Copy link
Contributor Author

Might not end up being needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants