-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated/unused support for examples in Renderer (keeping for numeric-input though) #1961
Conversation
…r numeric-input though)
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (5e29f46) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1961 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1961 |
Size Change: 0 B Total Size: 1.29 MB ℹ️ View Unchanged
|
@@ -123,8 +123,11 @@ export class NumericInput | |||
isFocused: false, | |||
}; | |||
|
|||
// TODO(Nicole, Jeremy): This is maybe never used and should be removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used, but only internal to the widget.
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, love to see a smaller external API
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Major Changes - [#1962](#1962) [`435280ac4`](435280a) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Move scoring utility functions out of `Util` object into their own file and only export externally used function (`keScoreFromPerseusScore`) - [#1961](#1961) [`d93e3ecde`](d93e3ec) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove deprecated/unused `examples()` function from `Renderer` ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`435280ac4`](435280a), [`d93e3ecde`](d93e3ec)]: - @khanacademy/[email protected] Author: khan-actions-bot Reviewers: jeremywiebe Required Reviewers: Approved By: jeremywiebe Checks: ⏭️ Publish npm snapshot, ✅ Cypress (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1964
Summary:
While working on SSS, I came across the
examples()
function on theRenderer
that was causing me issues (with threading client-side validation in).I checked and it is no longer used anywhere. Note that the
input-number
andnumeric-input
use their localexamples()
functions still to pass a set of examples to theInputWithExamples
component, which we're keeping.Implemented in D2749
Issue: LEMS-2561
Test plan:
yarn test
yarn typecheck
Checked in host webapp and the function is not used.