Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert svg-image changes #2001

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Revert svg-image changes #2001

merged 2 commits into from
Dec 13, 2024

Conversation

SonicScrewdriver
Copy link
Contributor

@SonicScrewdriver SonicScrewdriver commented Dec 13, 2024

Summary:

Undoing svg image changes to unblock Perseus.

Test plan:

  • simple revert.

@SonicScrewdriver SonicScrewdriver self-assigned this Dec 13, 2024
@SonicScrewdriver SonicScrewdriver changed the title <Replace this with your pull request title> Revert svg-image changes Dec 13, 2024
Copy link
Contributor

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (1c90ca4) and published it to npm. You
can install it using the tag PR2001.

Example:

yarn add @khanacademy/perseus@PR2001

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR2001

Copy link
Contributor

Size Change: +250 B (+0.02%)

Total Size: 1.27 MB

Filename Size Change
packages/perseus/dist/es/index.js 416 kB +250 B (+0.06%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 77.9 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 688 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 4.12 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

@SonicScrewdriver SonicScrewdriver merged commit ac07da0 into main Dec 13, 2024
8 checks passed
@SonicScrewdriver SonicScrewdriver deleted the undo-svg branch December 13, 2024 01:16
SonicScrewdriver added a commit that referenced this pull request Dec 13, 2024
SonicScrewdriver added a commit that referenced this pull request Dec 13, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @khanacademy/[email protected]

### Minor Changes

- [#2001](#2001)
[`ac07da03c`](ac07da0)
Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! -
Undoing changes to svg-image


- [#2004](#2004)
[`2135e0dc3`](2135e0d)
Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Fix
for svg-image loading issues.

### Patch Changes

- [#1928](#1928)
[`09d906cd2`](09d906c)
Thanks [@nishasy](https://github.com/nishasy)! - [SR] Add screenreader
support for circle graph


- [#1993](#1993)
[`99e55b623`](99e55b6)
Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Internal:
introduce `ValidationResult` for use in validation functions

## @khanacademy/[email protected]

### Patch Changes

- Updated dependencies
\[[`09d906cd2`](09d906c),
[`99e55b623`](99e55b6),
[`ac07da03c`](ac07da0),
[`2135e0dc3`](2135e0d)]:
    -   @khanacademy/[email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants