-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert svg-image changes #2001
Merged
Merged
Revert svg-image changes #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2748a1f.
SonicScrewdriver
changed the title
<Replace this with your pull request title>
Revert svg-image changes
Dec 13, 2024
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (1c90ca4) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2001 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2001 |
Size Change: +250 B (+0.02%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
mark-fitzgerald
approved these changes
Dec 13, 2024
Merged
SonicScrewdriver
added a commit
that referenced
this pull request
Dec 13, 2024
This reverts commit ac07da0.
SonicScrewdriver
added a commit
that referenced
this pull request
Dec 13, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Minor Changes - [#2001](#2001) [`ac07da03c`](ac07da0) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Undoing changes to svg-image - [#2004](#2004) [`2135e0dc3`](2135e0d) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Fix for svg-image loading issues. ### Patch Changes - [#1928](#1928) [`09d906cd2`](09d906c) Thanks [@nishasy](https://github.com/nishasy)! - [SR] Add screenreader support for circle graph - [#1993](#1993) [`99e55b623`](99e55b6) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Internal: introduce `ValidationResult` for use in validation functions ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`09d906cd2`](09d906c), [`99e55b623`](99e55b6), [`ac07da03c`](ac07da0), [`2135e0dc3`](2135e0d)]: - @khanacademy/[email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Undoing svg image changes to unblock Perseus.
Test plan: