Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert svg-image changes #2001

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Revert svg-image changes #2001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbb2f4e
Revert "New approach to svg-image (#1983)"
SonicScrewdriver Dec 13, 2024
1c90ca4
changeset
SonicScrewdriver Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .changeset/gentle-ties-drum.md → .changeset/smooth-hairs-jam.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
"@khanacademy/perseus": minor
---

Updating how svg-image loads data
Undoing changes to svg-image
8 changes: 0 additions & 8 deletions packages/perseus/src/__tests__/renderer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,6 @@ describe("renderer", () => {
jest.spyOn(Dependencies, "getDependencies").mockReturnValue(
testDependencies,
);

// Mocked for loading graphie in svg-image
global.fetch = jest.fn(() =>
Promise.resolve({
text: () => "",
ok: true,
}),
) as jest.Mock;
});

afterEach(() => {
Expand Down
61 changes: 0 additions & 61 deletions packages/perseus/src/components/__tests__/__snapshots__/svg-image.test.tsx.snap
View file
Open in desktop

This file was deleted.

122 changes: 0 additions & 122 deletions packages/perseus/src/components/__tests__/svg-image.test.tsx
View file
Open in desktop

This file was deleted.

Loading
Loading