Add test to document empty expression can be a correct answer #2003
+30
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremywiebe
commented
Dec 13, 2024
| @@ -125,12 +121,7 @@ export function scoreWidgetsFunctional( | |||
|
|
|||
| const userInput = userInputMap[id]; | |||
| const scorer = getWidgetScorer(widget.type); | |||
| const score = scorer?.( | |||
| userInput as UserInput, | |||
There was a problem hiding this comment.
This cast is no longer needed as we've tuned the types enough.
…be marked correct if coefficient == true
jeremywiebe
commented
Dec 13, 2024
| beforeEach(() => { | ||
| jest.spyOn(Dependencies, "getDependencies").mockReturnValue( | ||
| testDependencies, | ||
| ); | ||
| }); | ||
|
|
||
| it("is correct when input is empty but answer is 1 and coefficient: true", () => { |
There was a problem hiding this comment.
The expression widget is based on KhanAnswerTypes. And within that file there's a special case where it interprets a completely empty input (aka "") as 1!
So this is a behavioural test to document this because it's very non-obvious unless you trace through the KhanAswerTypes!
jeremywiebe
changed the title
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
RendererUtil: remove unnecessary cast to UserInput
Issue: LEMS-2561
Test plan: